search

rhtconsulting / puppet-jboss_admin

Puppet module for runtime configuration of a JBoss container
MIT License
15 stars 12 forks source link

add jboss_admin::pattern::security_domain_with_authentication_classic #16

Closed itewk closed 10 years ago

itewk commented 10 years ago

@cpitman What do you think of the idea of adding another layer to the mix? Operations. Essentially common combinations of resources. In this case the all to common combination of a security domain with classic authentication.

I could just add this to my in house module as a helper type but it seems like something lots of people will end up needing to do, so why not make it easy?

Assuming the idea in concept is good I am totally up for different naming if you have better ideas.

itewk commented 10 years ago

assuming the concept is sound I will also add some stuff to the documentation and I am sure a test would be a good idea too :)

cpitman commented 10 years ago

Yeah, I've been thinking about this for a while. I agree, we need something like this. I've debated whether it should be a different module, but for now lets keep them in here and just grow them as we have the need. operation implies action to me, how about pattern?

itewk commented 10 years ago

pattern sounds good to me. I'll refactor in the morning and re-submit. Any ideas on making the type name any shorter? It seems a bit verbose to me but couldn't think of anything shorter.

itewk commented 10 years ago

@cpitman I have updated the pull request to reflect your comments as well as adding a test and updating the README.

Though I have not figured out how to get vagrant to work on Fedora 20 yet so I have not been able to actually test my test.