search

rhtconsulting / puppet-jboss_admin

Puppet module for runtime configuration of a JBoss container
MIT License
15 stars 12 forks source link

jboss_exec is ignoring 'noop' attribte for 'unless' and 'onlyif' statements #73

Closed itewk closed 9 years ago

itewk commented 9 years ago

If the 'noop' attribute is set to true for a jboss_exec resource it is not being obayed for the 'onlyif' and 'unless' statements.

This causes a problem if jboss is stopped and the noop flag is being used to prevent any commands from being run against a stopped jboss instance.

itewk commented 9 years ago

@cpitman

I realize why in a normal exec the onlyif and unless are still run even in noop scenario, but for jboss_exec , at least for my use case it doesnt make sense. So unless you have another idea I don't know what else to do but to not have the unless and onlyif statements run if noop is set.

itewk commented 9 years ago

@cpitman

I am thinking we do this in the cli_provider for execute_command, if noop, then don't execute.

Thoughts?

itewk commented 9 years ago

@cpitman

Any chances of getting this merged before Monday?