search

rhtconsulting / puppet-jboss_admin

Puppet module for runtime configuration of a JBoss container
MIT License
15 stars 12 forks source link

comparisons should be done against strings not integers #77

Closed itewk closed 9 years ago

itewk commented 9 years ago

When doing comparisons for <, >, <=, >= the values are being converted to ints using .to_i

This makes doing comparisons of versions impossible, like "6.1.0.GA" < "6.2.2.GA"

cli_condition.rb should be updated to do .to_s for all comparisons.

itewk commented 9 years ago

@cpitman can you review this and merge?

itewk commented 9 years ago

merged.