search

rhtconsulting / puppet-jboss_admin

Puppet module for runtime configuration of a JBoss container
MIT License
15 stars 12 forks source link

can't convert nil into Array when noop enabled for jboss_batch #82

Closed itewk closed 9 years ago

itewk commented 9 years ago

There is a bug with the fix for issue #73 for jboss_batch resources. The following error is thrown if noop is enabled for the jboss_batch resource:

Error: /Stage[main]/....................../Jboss_batch[Local Authentication: Pre JBoss EAP 6.3.0]: Could not evaluate: can't convert nil into Array

This is because there is not a null check for the "is" parameter of the "insync?" function.

ramius345 commented 9 years ago

I have done a peer review of this change and it looks good to me. The added if statement will catch the case where the is is nil. The rest of the code is unchanged from the previous implementation and appears to be correct to the best of my knowledge.

itewk commented 9 years ago

@ramius345 thank you!

itewk commented 9 years ago

merged