rhtconsulting / rhc-ose

OpenShift Automation and Utilities by Red Hat Consulting
42 stars 34 forks source link

docker-registry-sync tag fails if images already exist on local docker client #105

Closed JayKayy closed 2 years ago

JayKayy commented 8 years ago

It may be designed this way intentionally and just the documentation is not there.

Problem:

It should be known or fixed that the awk for setting the image_id variable will set image_id equal to all the image id's that docker has locally(outside of this script). The current version of the script works with an absolute clean docker storage i.e. no images have been pulled by it before. Line: https://github.com/rhtconsulting/rhc-ose/blob/openshift-enterprise-3/docker-registry-sync#L15

When not clean storage then the docker tag attempt errors out looking like this

docker tag 3fc68076e184 <existing image ID> ... <existing image ID> <target registry>

Giving the error that docker tag requires 2 arguments.

etsauer commented 8 years ago

@JayKayy you think we could convert that thing to ansible? make it more idempotent?

JayKayy commented 8 years ago

@etsauer yea and it really shouldnt be that hard at all. Ill add this to my queue