Metrics

[JayKayy]

What does this PR do?

This is adding a role to automate setting up the Openshift integrated metrics using hawkular

How should this be manually tested?

ansible-playbook -i <configured inventory file> metrics.yml
ansible-playbook -i <configured inventory file> config-edit.yaml    

the second playbook simply adds both metrics and logging public urls to master-config.yaml and restarts openshift services.

Is there a relevant Issue open for this?

N/A

Who would you like to review this?

/cc @sabre1041 @etsauer @oybed

[etsauer]

@sabre1041 @oybed considering we don't have the middle pieces of these playbooks, how can we plan to test this?

[etsauer]

@JayKayy can you provide a sample of the inventory file you used to test? is it purely openshift-ansible variables, or is there more to it?

[sabre1041]

@etsauer I would recommend standing up an OSE environment and then to run the playbook with an inventory file configured to match the provisioned environment

[etsauer]

@sabre1041 agreed. let's have @JayKayy provide the minimal inventory file as mentioned in my inline comment above.

[detiber]

We have the following openshift-ansible PR to add metrics deployment support: https://github.com/openshift/openshift-ansible/pull/1582

[detiber]

We also have an 'adhoc' playbook (https://github.com/openshift/openshift-ansible/tree/master/playbooks/adhoc/metrics_setup) which does many of the steps here, it would be nice to consolidate any differences between the two approaches.

The playbooks/adhoc directory in openshift_ansible currently holds "unsupported" playbooks that are used mainly by OpenShift Ops (but there are some community members using and contributing to them as well). We'd welcome any contributions for additional adhoc playbooks for features/configuration that consulting needs, but is not in a state to be generically useful through the "supported" installation methods yet.

[etsauer]

@detiber i think this is a good idea. we definitely don't want to be repeating work that's being done. considering https://github.com/openshift/openshift-ansible/pull/1582, is there any usefulness in what we have here? or should we just look to contribute https://github.com/rhtconsulting/rhc-ose/pull/109 to 'adhoc'?

[detiber]

@etsauer reviewing/testing https://github.com/openshift/openshift-ansible/pull/1582 and highlighting any deficiencies you guys see would be a huge help.

Contributing https://github.com/rhtconsulting/rhc-ose/pull/109 to the adhoc playbooks would help with future efforts in productizing the logging installation for sure.

[etsauer]

@JayKayy based on the above, will you close this and #109 and re-create #109 as a PR against https://github.com/openshift/openshift-ansible ?

[JayKayy]

Sure ill get on that today

[JayKayy]

Opened PR here: https://github.com/openshift/openshift-ansible/pull/1636