search

rhtconsulting / rhc-ose

OpenShift Automation and Utilities by Red Hat Consulting
42 stars 34 forks source link

Add OpenStack SSH key parameter check #134

Closed vvaldez closed 8 years ago

vvaldez commented 8 years ago

What does this PR do?

Adds a check for the openstack_key_name parameter value. If it is not set it will fail and halt the playbook. The reason for this is if no key_name is set, the playbook will create instances but have no way to SSH into them so any remaining tasks will fail.

How should this be manually tested?

Attempt to run ose-provision.yml without openstack_key_name set. With this PR this will be caught in a pre_task run.

Is there a relevant Issue open for this?

No known issues.

Who would you like to review this?

/cc @oybed

oybed commented 8 years ago

Including @etsauer and @sabre1041 for review as well.

etsauer commented 8 years ago

lgtm.. @oybed you good if I merge?

oybed commented 8 years ago

Only comment from me is that now we're making the OSE provisioning somewhat more OpenStack specific - is there something we can do to add another abstraction to this?

etsauer commented 8 years ago

@oybed the addition is specifically in the openstack_create role, not any openshift roles, so that shouldn't be a concern.