Authors need to provide variable info to the roles/README

rhtconsulting / rhc-ose

OpenShift Automation and Utilities by Red Hat Consulting

42 stars 34 forks source link

Authors need to provide variable info to the roles/README #143

Closed JayKayy closed 8 years ago

JayKayy commented 8 years ago

What does this PR do?

Reopening pull request.

Dont merge this pull request until sufficient variable documentation has been provided by authors of the roles.

Please add comments so that I can fill the role README with the correct variable information for others to better understand how these roles can be used.

How should this be manually tested?

N/A

Is there a relevant Issue open for this?

N/A

Who would you like to review this?

/cc @sabre1041 @etsauer @oybed

sabre1041 commented 8 years ago

@JayKayy In the future, I would recommend creating an issue instead of a PR to collect feedback and suggestions as to keep the commit log cleaner

JayKayy commented 8 years ago

Valid point, Should i close this?

sabre1041 commented 8 years ago

@JayKayy yes that sounds good. This will give a good precedence to move forward with