search

rhtconsulting / rhc-ose

OpenShift Automation and Utilities by Red Hat Consulting
42 stars 34 forks source link

Change default_env_id of "testenv" to local env OS_USERNAME #148

Closed vvaldez closed 8 years ago

vvaldez commented 8 years ago

What does this PR do?

Changes the default for the default_env_id variable to use the local system's OS_USERNAME variable that should be sourced from a file similar to openrc.sh.

How should this be manually tested?

Run a playbook and do not specify the env_id variable so the default can be used. Verify the name contains your OpenStack username.

Is there a relevant Issue open for this?

None.

Who would you like to review this?

/cc @oybed @etsauer @sabre1041

oybed commented 8 years ago

This looks A_OK to me. @etsauer did you still want it to include the "testenv" in addition to the username? Just to easier identify which environments are truly temporary env v.s. "production" ?

etsauer commented 8 years ago

@oybed @vvaldez I think i still want something generic to identify it as one of ours. users are expected to put their username in any vm they create (even though they generally don't)

etsauer commented 8 years ago

make it "casl-username" :)

vvaldez commented 8 years ago

@oybed @etsauer done

oybed commented 8 years ago

I like it - ship it!!

vvaldez commented 8 years ago

Thanks! Together with #149 these will really help with large environments.