search

rhtconsulting / rhc-ose

OpenShift Automation and Utilities by Red Hat Consulting
42 stars 34 forks source link

openshift-provision pre_task should check for local install of openshift-ansible installer #178

Open vvaldez opened 8 years ago

vvaldez commented 8 years ago

When testing PR #168 end-to-end provisioning using a Fedora VM, I got this error:

TASK: [Run openshift installer] *********************************************** 
failed: [localhost] => {"changed": true, "cmd": ["ansible-playbook", "-e", "ansible_ssh_user=cloud-user", "-i", "./inventory_casl-vvaldez-HeLrixGQ", "/usr/share/ansible/openshift-ansible/playbooks/byo/config.yml"], "delta": "0:00:00.184761", "end": "2016-06-06 11:49:17.342460", "rc": 1, "start": "2016-06-06 11:49:17.157699", "warnings": []}
stderr: ERROR: the playbook: /usr/share/ansible/openshift-ansible/playbooks/byo/config.yml could not be found

I propose this be checked before starting the main playbook tasks/roles.

oybed commented 8 years ago

I'd suggest that we create a specific task / role that does all the "pre-checks" up front to avoid having to run 1/3 through the execution before getting the info - this should include all "prereqs" that we are aware of that is needed - including "access to the hosting env", "necessary subscriptions", etc. etc.