search

rhtconsulting / rhc-ose

OpenShift Automation and Utilities by Red Hat Consulting
42 stars 34 forks source link

Cleaned up hostname role to make it more generic #187

Closed oybed closed 8 years ago

oybed commented 8 years ago

What does this PR do?

Cleans up the hostname role to avoid using loops to set hostname. Also, removes the DNS tie to make the hostnames role more generic.

How should this be manually tested?

Provision an environment (e.g.: in OS1) and observe how the hostnames stays the same, but allows for custom dns domain - i.e.: set in the inventory file.

./provision.sh -i=<path_to_inventory> -p=<path_to_OSE_installer>

Also, custom hostnames can be set with the custom_hostname variable. To best test this, one may want to create a new playbook that just tests the hostnames role.

Is there a relevant Issue open for this?

resolves #180 resolves #181 resolves #183

Who would you like to review this?

/cc @etsauer @JayKayy

oybed commented 8 years ago

@etsauer just as a FYI - this has successfully tested with the incorporation of the change in #191 ... hence, may want to test/merge that change first, then I can update this PR with the latest to get it working.

oybed commented 8 years ago

@etsauer this PR has been updated, please have another look and re-test / merge if everything looks A_OK to you.

etsauer commented 8 years ago

looks great! merging.