rhtconsulting / rhc-ose

OpenShift Automation and Utilities by Red Hat Consulting
42 stars 34 forks source link

Creation of solutions folder including script to associate openshift … #190

Closed sabre1041 closed 8 years ago

sabre1041 commented 8 years ago

What does this PR do?

Folder structure for solutions. The initial solution involves allocating the secret that is used for Metrics and logging with the OpenShift signer instead of each individual components signer.

How should this be manually tested?

Review the folder structure. The script can be tested from an OpenShift master instance. To create the secrets for the metrics component, execute the following:

./certificates-secrets-metrics-logging.sh -t=metrics -h=hawkular-metrics.apps.example.com

Is there a relevant Issue open for this?

N/A

Who would you like to review this?

/cc @etsauer @oybed

oybed commented 8 years ago

@sabre1041 overall looks good - thanks for putting this together. A few minor nitpicks:

sabre1041 commented 8 years ago

@oybed thanks for the review. I'll go ahead and add the suggested improvements

sabre1041 commented 8 years ago

@oybed updated contents of PR. please review at your convenience

etsauer commented 8 years ago

lgtm. merging.