rhtconsulting / rhc-ose

OpenShift Automation and Utilities by Red Hat Consulting
42 stars 34 forks source link

Adds pre_task to checks to address Issue #178 #202

Closed vvaldez closed 8 years ago

vvaldez commented 8 years ago

What does this PR do?

Addresses Issue #178 by adding a pre_task check for openshift_ansible_path directory and openshift_ansible_playbook file and will halt the playbook if not found or accessible before any provisioning. Also adds the following to support this feature:

Run ose-provision.yml on a system without the default path of /usr/share/ansible/openshift-ansible or the playbooks/byo/config.yml to ensure the playbook fails. Also attempt specifying a custom path and/or playbook in an inventory or variables file.

Is there a relevant Issue open for this?

None.

Who would you like to review this?

/cc @oybed @etsauer @sabre1041

etsauer commented 8 years ago

@vvaldez why should ose-provision.yml care about the path to openshift-ansible? it doesn't ever call anything in openshift-ansible. the openshift-ansible/playbooks/byo/config.yml is called externally by the wrapper script.

etsauer commented 8 years ago

I'm going to close this as it doesn't seem to apply since we pulled the tie together of openshift-ansible out to a script.