search

rhtconsulting / rhc-ose

OpenShift Automation and Utilities by Red Hat Consulting
42 stars 34 forks source link

Malformed Docker Configuration File #210

Open sabre1041 opened 8 years ago

sabre1041 commented 8 years ago

After performing the latest ansible OpenShift provision using the tooling, the docker configuration file at /etc/sysconfig/docker is malformed. The OPTIONS property is used twice and the first occurrence has a ^ at the beginning

# /etc/sysconfig/docker

# Modify these options if you want to change the way the docker daemon runs
^OPTIONS='--selinux-enabled --insecure-registry 172.30.0.0/16'
DOCKER_CERT_PATH=/etc/docker

# If you want to add your own registry to be used for docker search and docker
# pull use the ADD_REGISTRY option to list a set of registries, each prepended
# with --add-registry flag. The first registry added will be the first registry
# searched.
ADD_REGISTRY='--add-registry registry.access.redhat.com'

# If you want to block registries from being used, uncomment the BLOCK_REGISTRY
# option and give it a set of registries, each prepended with --block-registry
# flag. For example adding docker.io will stop users from downloading images
# from docker.io
# BLOCK_REGISTRY='--block-registry'

# If you have a registry secured with https but do not have proper certs
# distributed, you can tell docker to not look for full authorization by
# adding the registry to the INSECURE_REGISTRY line and uncommenting it.
# INSECURE_REGISTRY='--insecure-registry'

# On an SELinux system, if you remove the --selinux-enabled option, you
# also need to turn on the docker_transition_unconfined boolean.
# setsebool -P docker_transition_unconfined 1

# Location used for temporary files, such as those created by
# docker load and build operations. Default is /var/lib/docker/tmp
# Can be overriden by setting the following environment variable.
# DOCKER_TMPDIR=/var/tmp

# Controls the /etc/cron.daily/docker-logrotate cron job status.
# To disable, uncomment the line below.
# LOGROTATE=false
#

# docker-latest daemon can be used by starting the docker-latest unitfile.
# To use docker-latest client, uncomment below line
#DOCKERBINARY=/usr/bin/docker-latest
OPTIONS=' --selinux-enabled --insecure-registry=172.30.0.0/16 --log-driver=json-file --log-opt max-size=50m'

When running any docker commands, the following message is also returned

/etc/sysconfig/docker: line 4: ^OPTIONS=--selinux-enabled --insecure-registry 172.30.0.0/16: No such file or directory
vvaldez commented 8 years ago

I've fixed this issue but curious if I need to add --log-driver=json-file --log-opt max-size=50m to this file in this task as in your example.