This PR changes how hostnames and domains are assigned based on the env_id variable.
If env_id is left disabled, the tools will auto-generate a unique id to be used - ex: 'master1.casl-userid-12312334.example.com'
If env_id is enabled, but left blank, (e.g.: env_id=), no id will be inserted - ex: 'master1.example.com'
If env_id is set to a fixed value, it will be used as the id - ex: if set to 'env1', the outcome will be 'master1.env1.example.com'
This can of course be used in conjunction with the dns_domain variable (and the newly introduced openshift_app_domain variable), to generate very custom FQDNs.
This PR also changes how volume names are assigned - i.e.: it will now be named according to the instance a volume is assigned to + the suffix _volume
How should this be manually tested?
Set env_id in the inventory file to various values, then run the provisioning to see the result, e.g.:
sabre1041
commented
8 years ago
What does this PR do?
This PR changes how hostnames and domains are assigned based on the
env_idvariable. If env_id is left disabled, the tools will auto-generate a unique id to be used - ex: 'master1.casl-userid-12312334.example.com' If env_id is enabled, but left blank, (e.g.: env_id=), no id will be inserted - ex: 'master1.example.com' If env_id is set to a fixed value, it will be used as the id - ex: if set to 'env1', the outcome will be 'master1.env1.example.com'This can of course be used in conjunction with the
dns_domainvariable (and the newly introducedopenshift_app_domainvariable), to generate very custom FQDNs.This PR also changes how volume names are assigned - i.e.: it will now be named according to the instance a volume is assigned to + the suffix
_volumeHow should this be manually tested?
Set
env_idin the inventory file to various values, then run the provisioning to see the result, e.g.:Is there a relevant Issue open for this?
resolves #208 resolves #216
Who would you like to review this?
/cc @etsauer @sabre1041