rhtconsulting / rhc-ose

OpenShift Automation and Utilities by Red Hat Consulting
42 stars 34 forks source link

Added quotes where needed and fixed some other minor bugs #244

Closed oybed closed 7 years ago

oybed commented 7 years ago

What does this PR do?

Fixes some minor bugs around quotes and checks for files/directories. Especially in those cases where there are more than one image of a similar name.

How should this be manually tested?

  1. Ensure no images already exists of the desirable name, e.g.: rhtconsulting/rhc-openstack-client
  2. Run the full script to generate the image and validate that it works

Is there a relevant Issue open for this?

N/A

Who would you like to review this?

/cc @etsauer

sabre1041 commented 7 years ago

@oybed @etsauer since the image has moved to another repository, can we close this PR?

oybed commented 7 years ago

@sabre1041 these changes are needed in the new repo as well. I'll move it over to the new place.