search

rhtconsulting / rhc-ose

OpenShift Automation and Utilities by Red Hat Consulting
42 stars 34 forks source link

Updating script, images list, documentation for new versions of opens… #247

Closed etsauer closed 7 years ago

etsauer commented 7 years ago

…hift

What does this PR do?

Updating registry sync script and image lists for provide image lists for 3.3.1.11 and 3.4.1.10

How should this be manually tested?

follow solutions/disconnected_installs/README.md

Is there a relevant Issue open for this?

n/a

Who would you like to review this?

/cc @oybed @sabre1041 @stratus-ss

sabre1041 commented 7 years ago

@etsauer Sync works well.

A couple notes:

1 Any way to add a counter as it is progressing through the list of images to sync. Such as "Syncing Image 3/25" to provide some additional insight into the progress.

  1. Link in README.md is in asciidoc format instead of markdown
  2. Should the "Create new OpenShift images file" be worded differently? It seems to imply that you must create a new file even though we provide a number of versions included in the repository
etsauer commented 7 years ago

@sabre1041 check out the changes i pushed. I added a counterof images completed. Note that the implementation of the counter is different depending on if you use --parallel or not. Also addressed your README concerns.