search

rhtconsulting / rhc-ose

OpenShift Automation and Utilities by Red Hat Consulting
42 stars 34 forks source link

Docker client run fix #52

Closed JaredBurck closed 8 years ago

JaredBurck commented 8 years ago

What does this PR do?

Updated run.sh script to split out check for docker service running and if docker image found.

When no docker image was found or had been previously built, the run.sh script would return 1 and error out with the message: "Error: Failed to determine installed docker images. Please verify connectivity to Docker socket".

How should this be manually tested?

Steps to recreate:

docker rmi {openstack-docker-client id}
./run.sh --repository=/path/to/repo

Same steps as above to verify this works after update.

Is there a relevant Issue open for this?

Previous PR #50 https://github.com/rhtconsulting/rhc-ose/pull/50

Who would you like to review this?

/cc @sabre1041

sabre1041 commented 8 years ago

@JaredBurck looks good.

One thing. Would you be able to update the text when the previous command returns a response >1 to indicate an error has occurred determining whether the image is present (awk/grep parsing error) rather than the image itself not being found