search

rhtconsulting / rhc-ose

OpenShift Automation and Utilities by Red Hat Consulting
42 stars 34 forks source link

Added which package to yum installation for jekyll build #94

Closed sabre1041 closed 8 years ago

sabre1041 commented 8 years ago

What does this PR do?

rvm requires which package to be present during jeykll build. This PR adds this to the list of installed packages

How should this be manually tested?

Make sure to have a version of the OpenShift Playbooks available locally

Navigate to docker/jekyll-asciidoc-docker folder and run the following

/run.sh --directory=<path_to_playbooks>

The container should build successfully and the playbook content can be viewed in a web browser at http://<docker_ip>:4000>

Is there a relevant Issue open for this?

None

Who would you like to review this?

/cc @etsauer

etsauer commented 8 years ago

@sabre1041 this looks fine, but can expand upon a little on the reason we need to add this? from what I can see, this test works just fine as is.

sabre1041 commented 8 years ago

@etsauer did a fresh docker build. Rvm install failed stating which was required and not found