rhubarbgroup / redis-cache

A persistent object cache backend for WordPress powered by Redis. Supports Predis, PhpRedis, Relay, replication, sentinels, clustering and WP-CLI.
https://wordpress.org/plugins/redis-cache/
GNU General Public License v3.0
439 stars 150 forks source link

Really fix all EC problems #391

Closed szepeviktor closed 2 years ago

szepeviktor commented 2 years ago

@tillkruss #390 was half-done and ❌failing.

tillkruss commented 2 years ago

The readme.txt changes won't work like that.

szepeviktor commented 2 years ago

Yes. Wrong sed command!

szepeviktor commented 2 years ago

@tillkruss I'd like to fix those few PHPStan ignores...

szepeviktor commented 2 years ago

Now everything should be 🍏

szepeviktor commented 2 years ago

Very strange! On my server "Ignored error pattern ... was not matched", in CI it is all green!

szepeviktor commented 2 years ago

Very strange! On my server "Ignored error pattern ... was not matched", in CI it is all green!

Got it! The cause is the latest release of PHPStan: v1.8.3