search

rhubarbgroup / redis-cache

A persistent object cache backend for WordPress powered by Redis. Supports Predis, PhpRedis, Relay, replication, sentinels, clustering and WP-CLI.
https://wordpress.org/plugins/redis-cache/
GNU General Public License v3.0
439 stars 150 forks source link

Test every supported release of Relay extension #409

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

@tillkruss How can one determine what versions are supported?

https://github.com/cachewerk/relay/releases

tillkruss commented 1 year ago

We support 7.4 - 8.2

szepeviktor commented 1 year ago

I mean Relay versions.

tillkruss commented 1 year ago

Elaborate?

szepeviktor commented 1 year ago

Currently we run a CI workflow (not just in this repo!) with only a single version of Relay extension. We should run CI with all supported Relay versions making sure that our supported versions all work properly.

tillkruss commented 1 year ago

We have >5000 tests for Relay, I'd say just test two version, something relatively recent and one old one.

szepeviktor commented 1 year ago

We have >5000 tests for Relay

Excuse me but union type was not spotted with those tests.

What Relay version is not supported?

tillkruss commented 1 year ago

We have >5000 tests for Relay Excuse me but union type was not spotted with those tests.

I'm referring to Relay, not the stubs. .stub.php files aren't actually valid PHP.

What Relay version is not supported?

I don't understand the question.

szepeviktor commented 1 year ago

I'm referring to Relay, not the stubs. .stub.php files aren't actually valid PHP.

AFAIK the union type is in the extension's code. In this repo's CI there are no stubs.

What Relay version is not supported?

I don't understand the question.

I'm trying to find out what Redis versions you support. Could you give me a list or a way to find out?