rhubarbgroup / redis-cache

A persistent object cache backend for WordPress powered by Redis. Supports Predis, PhpRedis, Relay, replication, sentinels, clustering and WP-CLI.
https://wordpress.org/plugins/redis-cache/
GNU General Public License v3.0
427 stars 149 forks source link

Add WP_REDIS_SSL setting, pass to predis and phpredis #450

Closed david-donachie closed 1 year ago

david-donachie commented 1 year ago

Simple fix to allow a WP_REDIS_SSL setting to pass SSL connection arguments in the case of a TLS service (such as Heroku) that needs additional SSL parameters.

connect_using_phpredis() sets an 'ssl' key on it's connection arguments derived from it via $parameters['ssl'], connect_using_predis() directly uses the $parameters['ssl'] value.

e.g.

    define('WP_REDIS_SSL', [
        'verify_host' => false,
        'verify_peer' => false,
        'verify_peer_name' => false,
    ]);
tillkruss commented 1 year ago

Closes #433.

david-donachie commented 1 year ago

I believe I've done all the requested changes

david-donachie commented 1 year ago

@tillkruss I think I've made all the changes you requested, but I still see the PR marked as requesting further changes. Is there something I've not yet done? Our deadline is approaching quickly, so if you need me to do something else, just let me know.