Fix AccelerateWP installation check

rhubarbgroup / redis-cache

A persistent object cache backend for WordPress powered by Redis. Supports Predis, PhpRedis, Relay, replication, sentinels, clustering and WP-CLI.

https://wordpress.org/plugins/redis-cache/

GNU General Public License v3.0

425 stars 148 forks source link

Fix AccelerateWP installation check #496

Closed sy-records closed 9 months ago

sy-records commented 9 months ago

The sidebar in the settings page is now not controlled by WP_REDIS_DISABLE_BANNERS, which should be wrong?

https://github.com/rhubarbgroup/redis-cache/blob/1f12771b2a83660da203cf79fe2df9a238f60d89/includes/ui/settings.php#L68-L72

tillkruss commented 9 months ago

Can you explain what's currently happening, and what you expect to happen?

sy-records commented 9 months ago

I want to hide Object Cache Pro in the settings page /wp-admin/options-general.php?page=redis-cache. But, I set the WP_REDIS_DISABLE_BANNERS constant to true, but it is not hidden.

That's intentional.