Passing null to parameter results in a warning when running in PHP 8.2.8

[sebastianthulin]

Description

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /var/www/stage/wp-content/object-cache.php on line 2538

Expected Behavior

The subject in the string replacement, should be checked if the type is valid before performing the string replacement. Thus avoiding throwing a warning.

Actual Behavior

A warning is thrown.

Possible Fix

protected function sanitize_key_part( $part ) {

        if( $part === null ) {
            return '';
        }

        return str_replace( ':', '-', $part );
    }

Steps to Reproduce

Shows up randomly.

Additional context

Want the solution to not throw uncecessary errors.

Environment

• Plugin version: 2.5.0
• PHP version: 8.2.8
• WordPress version: 6.4.3

[tillkruss]

@sebastianthulin: Do you want to open a PR? I'd probably use the null coalescing operator.

[sebastianthulin]

Certainly, I'll take care of that tomorrow. Thank you!

[sebastianthulin]

This seems to have been fixed by you 3 months ago like as follows:

return str_replace( ':', '-', is_scalar( $part ) ? (string) $part : '' );

This enhancement, however, has not yet been incorporated into a released version. Do you plan to make a new release in the near future?

https://github.com/rhubarbgroup/redis-cache/compare/2.5.0...develop

[tillkruss]

Right... I'll tag a version soon.