search

rhul-compsoc / royalhackaway-old

Depriciated RoyalHackaway Website
https://royalhackaway.com/
Apache License 2.0
3 stars 2 forks source link

Fixes HTML issues #26

Closed crablab closed 6 years ago

crablab commented 6 years ago

Passes HTML proofer tests to make Circle CI happy :blush:

Alex-CD commented 6 years ago

This update has broken a the background image on the homepage, and the navbar link.

You changed the id of the homepage section #'top' to '#full-height' in top.html. This breaks the html and navbar link that refers to it.

I'm going to push a commit in a second that fixes this.

crablab commented 6 years ago

Could you describe the issues with Circle CI a bit more please? :)

chebyrash commented 6 years ago

Yeah I don't think my review counts towards anything 😄

crablab commented 6 years ago

Changes merged in #27