rhunk / SnapEnhance

An Xposed module offering an enhanced Snapchat experience
https://t.me/snapenhance
GNU General Public License v3.0
1.23k stars 117 forks source link

"Disable Image Compression" does nothing #1090

Closed VenusIsJaded closed 3 months ago

VenusIsJaded commented 3 months ago

Description

Comparing "Disable Image Compression" on and off with the same picture makes no difference in compression, I also tried on many different pictures/screenshots with no difference in compression. For example, the image I send is a high quality 1080p screenshot with many details to see, and, it gets heavily compressed by Snapchat even with the feature on. It's exactly the same whether "Disable Image Compression" is on or off

Reproduction steps

  1. Send a high quality, detailed picture/screenshot with "Disable Image Compression" off in Snapchat
  2. Open SnapEnhance, turn on "Disable Image Compression"
  3. Restart Snapchat, and send the same picture/screenshot to compare

Logs

No response

Snapchat Version

12.88.0.43

SnapEnhance Version

2.1.0

Agreement

rhunk commented 3 months ago

Snapchat compression is technically disabled when you use it, but the file format is still jpeg, so it's compressed by default. If you want better media quality you can choose a format like png or webp.

VenusIsJaded commented 3 months ago

Snapchat compression is technically disabled when you use it, but the file format is still jpeg, so it's compressed by default. If you want better media quality you can choose a format like png or webp.

Choosing webp makes no difference, and png makes the image quality worse

rhunk commented 3 months ago

@VenusIsJaded can you share the original file as well as the downloaded file after upload?

VenusIsJaded commented 3 months ago

@VenusIsJaded can you share the original file as well as the downloaded file after upload?

It's weird because when I download the file after upload, it becomes high quailty but looks heavily compressed in Snapchat. I will send the original file, and a screenshot of the heavily compressed image on Snapchat. I will say that having png and disabling image compression on still makes no difference in quailty after downloading the file.

Screenshot_20240517-215224

The above is the original screenshot

Screenshot_20240530-150303

The above is the compressed Snapchat image with no media settings on or changed

Screenshot_20240530-150533

The above is the screenshot with "Disable Image Compression" and png on

The one with Disable Image Compression on and png on clearly doesn't disable compression, and actually looks worse than Snapchat's defaults media settings.

rhunk commented 3 months ago

@VenusIsJaded Can you clear the snapchat cache using the settings gear menu in the snapenhance app and tell me if the quality has changed for media already sent?

VenusIsJaded commented 3 months ago

@VenusIsJaded Can you clear the snapchat cache using the settings gear menu in the snapenhance app and tell me if the quality has changed for media already sent?

Sorry for the late reply but I did that, and it didn't make a difference