rhunk / SnapEnhance

An Xposed module offering an enhanced Snapchat experience
https://t.me/snapenhance
GNU General Public License v3.0
1.24k stars 115 forks source link

The Picture Quality becomes terrible when been almost send off #953

Closed IamNickerson closed 4 months ago

IamNickerson commented 4 months ago

Description

The Picture quality becomes terrible when been seen again by clicking on send and returning back to the image

When taken,

(These Pictures are been shot on Samsung Galaxy Flip 5 with Snapchat been modded with SnapEnhance)

1st Image

Before:

Screenshot_20240422_123926_Snapchat

After:

Screenshot_20240422_123954_Snapchat

There is some fade which is been seen in the after pic

2nd Image:

Before:

Screenshot_20240422_124027_Snapchat

After:

Screenshot_20240422_124033_Snapchat

The quality of picture turns bad and a color line is been visible.

Reproduction steps

  1. Go to Snapchat
  2. Take a Pic
  3. Go to Send and return back to the picture
  4. The picture quality changes.

Logs

None.

Config

{"downloader":{"state":null,"properties":{"save_folder":"content://com.android.externalstorage.documents/tree/primary%3ADCIM%2FSnapenhance%20","auto_download_sources":[],"prevent_self_auto_download":false,"path_format":["append_hash","append_date_time","append_type","append_username"],"allow_duplicate":false,"merge_overlays":false,"force_image_format":null,"force_voice_note_format":null,"download_profile_pictures":false,"opera_download_button":false,"download_context_menu":false,"ffmpeg_options":{"state":null,"properties":{"threads":4,"preset":null,"constant_rate_factor":30,"video_bitrate":5000,"audio_bitrate":128,"custom_video_codec":"","custom_audio_codec":""}},"logging":["success","progress","failure"],"custom_path_format":""}},"user_interface":{"state":null,"properties":{"friend_feed_menu_buttons":["conversation_info","stealth"],"amoled_dark_mode":true,"friend_feed_message_preview":{"state":null,"properties":{"amount":1}},"snap_preview":false,"bootstrap_override":{"state":null,"properties":{"app_appearance":null,"home_tab":null}},"map_friend_nametags":false,"prevent_message_list_auto_scroll":false,"streak_expiration_info":false,"hide_friend_feed_entry":false,"hide_streak_restore":false,"hide_quick_add_friend_feed":false,"hide_story_suggestions":[],"hide_ui_components":[],"opera_media_quick_info":false,"old_bitmoji_selfie":null,"disable_spotlight":false,"hide_settings_gear":false,"vertical_story_viewer":false,"message_indicators":[],"stealth_mode_indicator":false,"edit_text_override":[]}},"messaging":{"state":null,"properties":{"bypass_screenshot_detection":false,"anonymous_story_viewing":false,"prevent_story_rewatch_indicator":false,"hide_peek_a_peek":false,"hide_bitmoji_presence":false,"hide_typing_notifications":false,"unlimited_snap_view_time":false,"auto_mark_as_read":["snap_reply","conversation_read"],"loop_media_playback":false,"disable_replay_in_ff":false,"half_swipe_notifier":{"state":null,"properties":{"min_duration":0,"max_duration":20}},"message_preview_length":20,"call_start_confirmation":false,"auto_save_messages_in_conversations":[],"prevent_message_sending":[],"friend_mutation_notifier":[],"better_notifications":[],"notification_blacklist":[],"message_logger":{"state":true,"properties":{"keep_my_own_messages":false,"auto_purge":"3_days","message_filter":[]}},"gallery_media_send_override":false,"strip_media_metadata":[],"bypass_message_retention_policy":false,"bypass_message_action_restrictions":false,"remove_groups_locked_status":false}},"global":{"state":null,"properties":{"better_location":{"state":null,"properties":{"spoof_location":false,"coordinates":{"lat":0.0,"lng":0.0},"always_update_location":false,"suspend_location_updates":false,"spoof_battery_level":"","spoof_headphones":false}},"snapchat_plus":false,"disable_confirmation_dialogs":[],"disable_metrics":false,"disable_story_sections":[],"block_ads":false,"disable_permission_requests":[],"disable_memories_snap_feed":false,"spotlight_comments_username":false,"bypass_video_length_restriction":null,"default_video_playback_rate":1.0,"video_playback_rate_slider":false,"disable_google_play_dialogs":false,"force_upload_source_quality":false,"default_volume_controls":false,"hide_active_music":false,"disable_snap_splitting":false}},"rules":{"state":null,"properties":{"stealth":"whitelist","auto_download":"whitelist","auto_save":"blacklist","auto_open_snaps":null,"unsaveable_messages":null}},"camera":{"state":null,"properties":{"disable_cameras":[],"immersive_camera_preview":false,"black_photos":false,"front_custom_frame_rate":null,"back_custom_frame_rate":null,"hevc_recording":false,"force_camera_source_encoding":false,"custom_resolution":"","override_front_resolution":null,"override_back_resolution":null}},"streaks_reminder":{"state":null,"properties":{"interval":1,"remaining_hours":13,"group_notifications":true}},"experimental":{"state":null,"properties":{"native_hooks":{"state":null,"properties":{"disable_bitmoji":false}},"session_events":{"state":null,"properties":{"capture_duplex_events":true,"allow_running_in_background":true}},"spoof":{"state":null,"properties":{"play_store_installer_package_name":false,"fingerprint":"","android_id":"","remove_vpn_transport_flag":false,"remove_mock_location_flag":false,"randomize_persistent_device_token":false}},"convert_message_locally":false,"new_chat_action_menu":false,"media_file_picker":false,"story_logger":false,"call_recorder":false,"account_switcher":{"state":null,"properties":{"auto_backup_current_account":true}},"edit_message":false,"app_lock":{"state":true,"properties":{"lock_on_resume":true}},"infinite_story_boost":false,"meo_passcode_bypass":false,"no_friend_score_delay":false,"e2ee":{"state":null,"properties":{"encrypted_message_indicator":false,"force_message_encryption":false}},"hidden_snapchat_plus_features":false,"custom_streaks_expiration_format":"","add_friend_source_spoof":null,"disable_composer_modules":"","prevent_forced_logout":false}},"scripting":{"state":null,"properties":{"developer_mode":false,"module_folder":"modules","auto_reload":null,"integrated_ui":false,"disable_log_anonymization":false}},"_locale":"en_US"}

Snapchat Version

12.82.0.51

SnapEnhance Version

2.0.2

Agreement

rhunk commented 4 months ago

@IamNickerson Can you export and share your config here please?

IamNickerson commented 4 months ago

@rhunk How? Please further explain how can i export the config?

IamNickerson commented 4 months ago

Ok found out first time how to export my SnapEnhance config (Been Mentioned Fully in the Top Comment) config.json

rhunk commented 4 months ago

@IamNickerson You haven't activated anything related to the camera can you tell me if the bug recurs without SnapEnhance installed/patched?

IamNickerson commented 4 months ago

This doesnt happen when SnapEnhance is not installed/Patched

TheTrueDonDotta commented 4 months ago

I've had this problem too i think it's to do with how shading or lighting works with cameras. it changes when i reposition the camera and take a photo

IamNickerson commented 4 months ago

Why is it getting compressed?

bocajthomas commented 4 months ago

@IamNickerson send the photos as photos not Screenshots thanks

IamNickerson commented 4 months ago

Then how can i say it is before effect and the after effect?

IamNickerson commented 4 months ago

Because quality changes but anyways i will send a photo not screenshot then

rhunk commented 4 months ago

@IamNickerson Please send a snap to someone without doing the bug and one with the bug. Then download them using the context menu of snapenhance and upload them here. Also make sure you have disabled "Force Image Format" in settings

IamNickerson commented 4 months ago

@IamNickerson Please send a snap to someone without doing the bug and one with the bug. Then download them using the context menu of snapenhance and upload them here. Also make sure you have disabled "Force Image Format" in settings Can i use the opera download button?

IamNickerson commented 4 months ago

Before:

3b69ac01_nickkrishna05_2024-04-24_18-39-06

After:

3da51b88_nickkrishna05_2024-04-24_18-48-39

2nd image

Before:

73af9580_nickkrishna05_2024-04-24_18-59-58

After:

df376779_nickkrishna05_2024-04-24_19-00-27

IamNickerson commented 4 months ago

Done with downloading with context menu the force image format was disabled by default

IamNickerson commented 4 months ago

The thing I noticed is that the before images is having higher KB compared to the after it seems like it is getting compressed after viewing it again

bocajthomas commented 4 months ago

The thing I noticed is that the before images is having higher KB compared to the after it seems like it is getting compressed after viewing it again

Yes it's definitely getting compressed @rhunk So SnapEnhance is doing this 🤔

rhunk commented 4 months ago

It only seems that the preview is optimized for display, but that this doesn't affect the photo sent. In any case, compression seems nonexistent so it's not worth spending hours of research to fix this problem, which isn't really a problem at all