rhysd / NyaoVim

Web-enhanced Extensible Neovim Frontend
Other
2.22k stars 57 forks source link

UNMET PEER DEPENDENCY react@^15.0.2 #106

Closed mdxprograms closed 7 years ago

mdxprograms commented 7 years ago

I'm using node 7.2 with neovim 0.1.7 I'm getting UNMET PEER DEPENDENCY react@^15.0.2 on install

Expected Behavior

Expect to install successfully with npm i -g nyaovim

Actual Behavior

npm fails to install React dependency

Steps to Reproduce (including precondition)

run: npm i -g nyaovim using node -v 7.2 and using neovim 0.1.7

Screenshot on This Problem (if possible)

screen shot 2016-12-09 at 10 22 10 pm

Your Environment

rhysd commented 7 years ago

Yeah, it's intentional. NyaoVim uses flux with Polymer. And some APIs of flux require React. It's because flux adds React as peer dependency. However, NyaoVim doesn't use the APIs. So NyaoVim doesn't need to meet the peer dependency.

mdxprograms commented 7 years ago

ahh gotcha. That stinks that it's so tightly coupled but I guess since that's what it was initially created for it defaults. Closing since it still works as expected! Thanks for the explanation. 👍