rhysd / NyaoVim

Web-enhanced Extensible Neovim Frontend
Other
2.22k stars 57 forks source link

Replace typings with @types by npm #115

Closed chitoku-k closed 7 years ago

chitoku-k commented 7 years ago

What was a problem?

Some type definitions are out-of-date and the project didn't compile.

How this PR fixes the problem?

Remove typings and install npm's equivalent of packages instead.

Check lists (check x in [ ] of list items)

Additional Comments

It is made sure that the build has gotten rid of any errors and test scripts seemed to have run.

An ugly workaround is inserted into renderer/main.html due to an issue caused by the latest version of TypeScript (2.3.2). It would be better if removed.

See: javascript - Uncaught ReferenceError: exports is not defined in filed generated by Typescript - Stack Overflow

rhysd commented 7 years ago

I confirmed this works. Thank you.