search

rhysd / NyaoVim

Web-enhanced Extensible Neovim Frontend
Other
2.22k stars 57 forks source link

Associate Nyaovim with common text files in OSX #121

Closed haifengkao closed 7 years ago

haifengkao commented 7 years ago

What was a problem?

Link Nyaovim to common text files in OSX.

How this PR fixes the problem?

Extend Info.plist to cover common text files The file extension list is copied from sublime text

Note this PR covers https://github.com/rhysd/NyaoVim/pull/120 Therefore, https://github.com/rhysd/NyaoVim/pull/120 should not be used if this PR is accepted.

Check lists (check x in [ ] of list items)

Additional Comments (if any)

love you~~~

rhysd commented 7 years ago

I'm not releasing OS X package with this command yet, but it looks good. Thank you for the update and I apologize late response.

rhysd commented 7 years ago

@haifengkao Could you merge the upstream master branch? I think CI will pass by it.

haifengkao commented 7 years ago

I did. Hope that it will pass the CI

rhysd commented 7 years ago

Hm, I don't know why CI fails... Installing 'neovim' package via PPA does not work.

haifengkao commented 7 years ago

I guess it's fine to remove sublime related extension

rhysd commented 7 years ago

I missed important point.

To include the file from SublimeText, we need to clarify it's ok in terms of license of Sublime text. This PR does not contain any license description. And Sublime text is a proprietary software. I want to ensure that including the file from Sublime text does not cause any problem.

haifengkao commented 7 years ago

hmm... I don't think this file is protected by the copyright law. The law only protects the content that shows creativeness. This file is a standard form required by apple. I can write my own form, but the result is pretty much the same.

rhysd commented 7 years ago

um, I agree that this feature is awesome, but it's not acceptable to include a file whose license is unclear. How about Atom or VS Code?

haifengkao commented 7 years ago

atom's file is here https://github.com/atom/atom/blob/master/resources/mac/atom-Info.plist They looks pretty much the same. I guess I need to teach githubbers the correct copyright knowledge.

rhysd commented 7 years ago

I think we can use Atom's plist file instead because Atom is licensed with MIT license. We can copy the file, and write the license description (copyright notice) as comment in it.

haifengkao commented 7 years ago

Copyrightability of Tables, Charts, and Graphs can give you some info about copyright laws.

haifengkao commented 7 years ago

as you requested.

rhysd commented 7 years ago

Thank you.

I confirmed CI is also broken in master branch.

https://travis-ci.org/rhysd/NyaoVim/builds/263804261

I'll merge this PR and then will fix CI job.

haifengkao commented 7 years ago

I guess it's very hard to change people's mind with the facts.