rhysd / NyaoVim

Web-enhanced Extensible Neovim Frontend
Other
2.22k stars 57 forks source link

README example is incorrect #65

Closed haifengkao closed 8 years ago

haifengkao commented 8 years ago

argv is not a dom attribute, it should not use $=. See Annotated attribute binding

Expected Behavior

<neovim-editor
    id="nyaovim-editor"
    argv="[[argv]]"
    font-size="14"
    font="Ricty,monospace"
    line-height="1.5"
></neovim-editor>

Actual Behavior

<neovim-editor
    id="nyaovim-editor"
    argv$="[[argv]]"
    font-size="14"
    font="Ricty,monospace"
    line-height="1.5"
></neovim-editor>

Steps to Reproduce (including precondition)

Just check the source code