search

rhysd / NyaoVim

Web-enhanced Extensible Neovim Frontend
Other
2.22k stars 57 forks source link

support double click to open a file #95

Closed haifengkao closed 8 years ago

haifengkao commented 8 years ago

What was a problem?

nyaovim doesn't open the file when a user double-clicks it

How this PR fixes the problem?

open-file event might be sent before ready event is emitted put the path in argv to let nyaovim-app to pick it up later

Check lists (check x in [ ] of list items)

rhysd commented 8 years ago

Good point! Thank you for your patch. Please check the review comments.

haifengkao commented 8 years ago

I have added the OSX check for arguments

rhysd commented 8 years ago

Thank you. It looks acceptable. I may add more refactoring later.