search

rhysd / Shiba

Rich markdown live preview app with linter
774 stars 55 forks source link

Printing does not work because of `overflow: auto` #17

Closed garaemon closed 9 years ago

garaemon commented 9 years ago

I found printing does not work on shiba because of overflow: auto.

Scroll bar of shiba comes from overflow: auto but it may hide second and subsequent sheets.

This patch may resolve this issue but I don't know this is correct way to fix the issue.

rhysd commented 9 years ago

Hi. Thank you for your report and patch! I'll check it.

garaemon commented 9 years ago

By applying this patch, shiba can generate pdf like following (with default README.md):

screenshot from 2015-09-23 19 55 19

But I'm afraid this patch is too tricky...

rhysd commented 9 years ago

I tried the patch. But it can't be merged because drawer and preview are scrolled synchronously. I think printer feature of Chrome has a collision with Polymer's drawer component.

garaemon commented 9 years ago

hmm, tough issue :sob:

ghost commented 9 years ago

Can you create a print-only style-sheet that only applies to printing? Would that help?

rhysd commented 9 years ago

media query may help to solve this issue. I'll try it!

ghost commented 9 years ago

media query may help to solve this issue. I'll try it!

:four_leaf_clover: good luck!

garaemon commented 9 years ago

media query may help to solve this issue. I'll try it!

:clap: awesome!

rhysd commented 9 years ago

Sorry for the delay. I fixed as below.

2015-10-25 17 30 34

ghost commented 9 years ago

thanks this is fantastic. :+1: :trophy: