rhysd / Shiba

Rich markdown live preview app with linter
772 stars 57 forks source link

Printing to PDF on Windows is not working #33

Closed nicpolhamus closed 6 years ago

nicpolhamus commented 8 years ago

Whenever I am attempting to print to pdf on Windows, my machine uses bioPDF to print to pdf. I am able to print a test page with bioPDF, and can print to pdf using Word. I'm unsure if the issue is truly with Shiba, or bioPDF.

rhysd commented 8 years ago

I'll check with my Windows machine tomorrow :smiley:

Naramsim commented 8 years ago

Me too, using default PDF Printer

rhysd commented 8 years ago

I'm sorry for latency. I confirmed below points for this issue.

Electron version is 1.4.1 for Shiba, and DemoApp's Electron version looks old. I need to check this on latest Electron.app.

rhysd commented 8 years ago

Electron v1.4.1 on Windows is also OK. So I confirmed this is an issue of Shiba.

nicpolhamus commented 7 years ago

Hello, any update to this issue? Thanks.

rhysd commented 7 years ago

I confirmed this issue again with the latest.

Now it seems to work on Electron v1.7.8. I tried to print a markdown document to PDF file as following.

default

I'll release Shiba v1.0.5 for large dependencies updates.

rhysd commented 6 years ago

I'm closing this issue because v1.1.0 was released. If someone notices this issue still occurs, please let me know by leaving a comment here.