search

rhysd / Shiba

Rich markdown live preview app with linter
772 stars 57 forks source link

Emoj does not show #34

Closed spencerimp closed 7 years ago

spencerimp commented 7 years ago

Hi Shiba developers,

Just a report that some of the emoj are not rendered in Shiba on my macOX Sierra

  1. :checkered_flag:
  2. :white_check_mark:
  3. :green_heart:
  4. :arrow_up:
  5. :arrow_down:

The screenshot is attached as follows shiba

rhysd commented 7 years ago

Nice catch! Emojis had been added before Sierra was public. I need to update them.

rhysd commented 7 years ago

I found that marked parses :foo_bar: into two piecies; the text :foo and the italic text _bar:. So this is originally the issue of marked. But marked will not implement emoji because it's not a markdown standard stuff. We need to handle parsing emojis by our side.

rhysd commented 7 years ago

I fixed in above commit. 1.0.4 will be released after I confirmed behavior on Linux and Windows (my dev environment is OS X).

2016-11-29 15 42 03