search

rhysd / changelog-from-release

Simple changelog generator from GitHub releases
https://github.com/rhysd/changelog-from-release/blob/master/CHANGELOG.md
MIT License
83 stars 14 forks source link

use jq -r to strip quotes #23

Closed linde12 closed 1 year ago

linde12 commented 1 year ago

Use jq -r .release.tag_name in order to strip the extra quotes you get from jq otherwise.

Before a version could look like this: "1.2.3" With this change it becomes: 1.2.3

This also affetcts branch names so instead of changelog-"1.2.3" we get changelog-1.2.3. This is good because fetching branches containing quotes can cause issues on Windows systems.

linde12 commented 1 year ago

Example of Windows error which is fixed by removing the quotes:

$ git pull
error: cannot lock ref 'refs/remotes/origin/changelog-"0.1.2-beta.1"': Unable to create 'C:/Path/To/Repo/.git/refs/remotes/origin/changelog-"0.1.2-beta.1".lock': Invalid argument
rhysd commented 1 year ago

Thanks for catching this.

linde12 commented 1 year ago

@rhysd No, thank you for the action!

Any plans on releasing soon, or should we go with using @master for now?