search

rhysd / changelog-from-release

Simple changelog generator from GitHub releases
https://github.com/rhysd/changelog-from-release/blob/master/CHANGELOG.md
MIT License
83 stars 14 forks source link

Credentials in the changelog #9

Closed maxim-smirnov closed 2 years ago

maxim-smirnov commented 2 years ago

I think it would be great to strip credentials provided in .git/config

Here is the result if you're using GitHub personal tokens.

<a name="v1.0.10"></a>
 # [v1.0.10](https://maxim-smirnov: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@github.com/maxim-smirnov/homebridge-neptun-smart/releases/tag/v1.0.10) - 11 May 2022

 **fix:** Now using unique name for valves of the second group

 **Full Changelog**: https://github.com/maxim-smirnov/homebridge-neptun-smart/compare/v1.0.9...v1.0.10

 [Changes][v1.0.10]
rhysd commented 2 years ago

Is https://github.com/maxim-smirnov/homebridge-neptun-smart/releases/tag/v1.0.10 the URL you expected?

maxim-smirnov commented 2 years ago

The result link represents the commit, where I’ve committed my token :)

And the code block just shows the beginning of CHANGELOG.md.

rhysd commented 2 years ago

@maxim-smirnov I added fix for this issue at ef2a40c. Can you confirm the fix?

cd /path/to/your/repository
go install github.com/rhysd/changelog-from-release
changelog-from-release
maxim-smirnov commented 2 years ago

I've checked the commit. Seems like it's fixed! Can you please provide new release with the binary? Thanks!

rhysd commented 2 years ago

Yes, I'll make a new release once other fixes are confirmed.

rhysd commented 2 years ago

v2.2.4 was released.