rhysd / clever-f.vim

Extended f, F, t and T key mappings for Vim.
https://rhysd.github.io/clever-f.vim
1.01k stars 44 forks source link

Take coverage of tests for Migemo/utf8 #36

Closed ichizok closed 6 years ago

ichizok commented 6 years ago

http://rhysd.hatenablog.com/entry/2017/11/27/091003

Vim 8.0.1372 (https://github.com/vim/vim/commit/ac112f01a6930c9d15cf0360b657373699916bfd) should have resolved covimerage error.

rhysd commented 6 years ago

Thank you for this patch. This patch must improve running tests so I plan to merge this after above tiny review comments are fixed.

By this patch, on Vim 8.0.1372 or later, coverage for migemo feature can be taken. However, Vim on Travis CI is older. So I cannot confirm this patch works. Did you try this patch with the Vim after 8.0.1372 and confirmed it works?

codecov-io commented 6 years ago

Codecov Report

Merging #36 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   90.87%   90.87%           
=======================================
  Files           3        3           
  Lines         285      285           
=======================================
  Hits          259      259           
  Misses         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c908a26...a58a9f8. Read the comment docs.

ichizok commented 6 years ago

By this patch, on Vim 8.0.1372 or later, coverage for migemo feature can be taken. However, Vim on Travis CI is older. So I cannot confirm this patch works. Did you try this patch with the Vim after 8.0.1372 and confirmed it works?

I confirmed only in my local. Would you like to add build-phase of latest Vim to CI (as with vital.vim) ?

ichizok commented 6 years ago

Homebrew macvim was updated to 8.0-143 (https://github.com/Homebrew/homebrew-core/commit/e84b6ac35e92aea912bf29ef2539483076f9973e) a few minutes ago.

rhysd commented 6 years ago

@ichizok Thank you for your fixes. Looks good. I'll check the result of merge commit to see if it works.