[RFC] Add feature to highlight characters to which the cursor can be moved directly

rhysd / clever-f.vim

Extended f, F, t and T key mappings for Vim.

https://rhysd.github.io/clever-f.vim

1.01k stars 44 forks source link

[RFC] Add feature to highlight characters to which the cursor can be moved directly #47

Closed yuntan closed 5 years ago

yuntan commented 5 years ago

This PR adds feature to highlight characters to which the cursor can be moved directly.

demo screen cast (fgj^fm):

This behavior is like deris/vim-shot-f and previously mentioned in #29 . This PR introduces two variables g:clever_f_mark_direct and g:clever_f_mark_direct_color.

TODO

[x] fix tests
[x] add document

NOTE This PR doesn't add migemo support.

rhysd commented 5 years ago

Thank you for the fixes. Is this PR ready for final review or still WIP?

yuntan commented 5 years ago

The last thing to do is documentation. The code is ready for review.

rhysd commented 5 years ago

OK, let me check the implementation.

rhysd commented 5 years ago

Do you want to write documentation? If you don't, it's ok to write up it by me after merging this.

yuntan commented 5 years ago

wrote document. The documentation is ready for review.

Do you think make g:clever_f_mark_direct = 1 default?

rhysd commented 5 years ago

Thank you for your suggestion. But clever-f.vim is a long live plugin. So I'm conservative against changing default behavior. Let me leave this feature optional for now.

yuntan commented 5 years ago

OK. Thank you!