search

rhysd / committia.vim

A Vim plugin for more pleasant editing on commit messages
MIT License
731 stars 30 forks source link

Use language neutral regex to find edit region #38

Closed st31ny closed 6 years ago

st31ny commented 6 years ago

I think, at least for me, #36 is caused by the language-dependent regular expression in git.vim. Just matching for the first comment line fixes the issue for me.

rhysd commented 6 years ago

oh, I did not know that the message can be localised. Thank you for this patch. I could not find out the root cause. What is message shown in your commit buffer instead?

rhysd commented 6 years ago

Anyway, I think it should not depend on the message. I will merge this fix.

st31ny commented 6 years ago

Well, it's basically the German translation of the English text:

# Bitte geben Sie eine Commit-Beschreibung für Ihre Änderungen ein. Zeilen,
# die mit '#' beginnen, werden ignoriert, und eine leere Beschreibung
# bricht den Commit ab.

Thanks for merging!

rhysd commented 6 years ago

I see. I didn't know the text message may be translated. Thank you for the information. I also fixed the similar issue at 40d81f2ef2266ab5ef73e0d67b5432bd740350ba.