fix definitions for committia-scroll-diff-up/down

[lesguillemets]

This is a pull request for issue #51 .

[rhysd]

Thanks for adding this but I fixed #51 not modifying j/k to <C-e>/<C-y>.

[rhysd]

Do you prefer using <C-e>/<C-y> to j/k? If so, please add new maps rather than modifying existing ones.

[lesguillemets]

Hi, thank you for the fix and your kind instructions!

I do prefer <C-e> over j here. However, we can always create mappings on our side, so I have no problem if these mappings are not defined in the plugin itself. (Unless you're actively willing, of course.)

Let me share my rationale, in case it's convincing:

• When calling <Plug>(committia-scroll-diff-*) mappings, I want to change the viewport of the window that shows the diff while editing the commit message.
• For example, when I need to see the next page of the diff, I'll call <Plug>(committia-scroll-diff-down-page), which is akin to CTRL-f.
• If I need to see a few more lines... <Plug>(committia-scroll-diff-down) ?
  • Calling committia#scroll_window('diff', 'j') moves the cursor in the diff buffer. Display-wise, this does nothing until the cursor reaches the bottom of the window.
  • <C-e> immediately scrolls the diff window, which is the expected behaviour for me.

If you find this convenient yourself, we could discuss the name for the mapping (Is <Plug>(committia-scroll-diff-down-line) good?), but you can just close this and make a commit yourself. (Waiting for my commit and merging won't worth the trouble)

Otherwise, please disregard this pull request. Thank you very much for your time.

[rhysd]

Makes sense. Let's use <C-e>/<C-y> instead of j/k. Merging.

[lesguillemets]

Thank you very much!