Allow option for hiding version information

rhysd / electron-about-window

'About This App' mini-window for Electron apps

https://www.npmjs.com/package/about-window

MIT License

413 stars 45 forks source link

Allow option for hiding version information #25

Closed alexanderturinske closed 6 years ago

alexanderturinske commented 6 years ago

Fixes #24

rhysd commented 6 years ago

I'm sorry that I failed to catch this PR. Let me review.

rhysd commented 6 years ago

@alexanderturinske Could you show me the screenshot how it looks like when setting use_version_info to false? And could you please add the option to .d.ts file and README.md?

alexanderturinske commented 6 years ago

@rhysd

Screenshot added to the commit.
Added option to README
Option was already in .d.ts, but not documented in README that it was

rhysd commented 6 years ago

I will publish new version after merging #26

bampakoa commented 6 years ago

@rhysd I think that this PR did not make it to the latest release 🤔 It seems that the if statement is missing from renderer.js

rhysd commented 6 years ago

@bampakoa Thank you for reporting that. I released 1.12.1. Could you try it?

bampakoa commented 6 years ago

@rhysd it works fine in 1.12.1 Thanks a lot!