rhysd / electron-about-window

'About This App' mini-window for Electron apps
https://www.npmjs.com/package/about-window
MIT License
409 stars 46 forks source link

used innerHtml to include link to 3rd party deps but link opens both about window and default browser #42

Closed gpinkham closed 4 years ago

gpinkham commented 4 years ago

So I included some links to 3rd party dependencies in my copyright in the about window. standard a href.. clicking those opens the link in the system's default browser but also in the about window. So it seems like the will-navigate and/or new events are captured but the event prevention is not happening (or some other event is propagating the navigation within the about window. I did experiment and added target="_blank" to the a tags.. this got me a different result (but also not desired).. the link opens in system default browser and a new electron window with the about window remaining intact.. has anyone else noticed this? seems like linking to 3rd party deps would be a pretty standard thing. Is there some sort of trick to getting this to function with about window remaining intact and the link opening in the system default browser (I'd even be ok with a new electron window)..

thanks!

about-window: 1.13.1 electron: 4.2.4 chrome: 69.0.3497.128 node: 10.11.0 v8: 6.9.427.31-electron.0