search

rhysd / electron-about-window

'About This App' mini-window for Electron apps
https://www.npmjs.com/package/about-window
MIT License
414 stars 45 forks source link

Version should be overridable by custom version string #51

Closed peanutbother closed 3 years ago

peanutbother commented 4 years ago

I use about-window to provide an api for plugins which can show an about window on their own. This works as designed, but the version displayed is the version of the host app, since about.html shows the version of remote.app.getVersion() instead of package.json's version .

It would be beneficial to first use options.version then lookup package.json's version, then fallback to remote.app.getVersion()

I can provide a PR for this soon, if desired. else I will resort to roll my own fork of this cool package

let me know your thought,

cheers