search

rhysd / electron-about-window

'About This App' mini-window for Electron apps
https://www.npmjs.com/package/about-window
MIT License
409 stars 46 forks source link

Disable contextIsolation option #64

Closed kondoumh closed 3 years ago

kondoumh commented 3 years ago

About window is no longer rendered in Electron v12. The cause seems to be that contextIsolation in webPreferences is set to true by default. Rendered when contextIsolation was set to false.

rhysd commented 3 years ago

Thanks for catching this. Yeah, context isolation is enabled by default now. And this library depends on that context isolation is disabled because it directly receives IPC messages. To enable context isolation, we need to use preload script. Meanwhile, simply disabling it makes sense to me.