Add highlight border color variable

[ecosse3]

Hi,

It would be nice if you add the ability to set highlight border color. I use this plugin pretty often and I've started using lspsaga.nvim so I would like to set the colors of git-messenger to be similar to all my IDE.

Linking background color works as expected but without border, it's hard to recognize popup.

LspSaga border style:

Current git-messenger popup (hard to see):

Thanks!

[rhysd]

My recommendation is setting different background color from Normal for NormalFloat or gitmessengerPopupNormal.

My recommended config is below:

autocmd ColorScheme * highlight link gitmessengerPopupNormal CursorLine

Does this work fine in your environment? Or do you still want border?

[phelipetls]

Neovim now has an API to add border to floating windows. Would it be easy to add configuration for this? For example, let g:git_messenger_border = "single" to pass { border: "single" } to nvim_open_win.

[rhysd]

Looks good. I didn't know Neovim's float window supports borders since it had not supported it when I'd implemented this plugin.

[rhysd]

@ecosse3 @phelipetls I tried border window and felt that margin was not necessary when border existed. So I tried to implement to make margin configurable at margin-removable branch.

Do you think you want this feature?

compared to

[phelipetls]

Yes, that'd be great! Thanks for the plugin.

[gegoune]

I prefer with margins. :)

[rhysd]

@phelipetls @cloggier

Thank you for your feedbacks. Since adding/removing margin is separate configuration from floating window options, it's possible to add both border and margin. I'll merge this into master after adding some tests.