rhysd / neovim-component

<neovim-editor> WebComponent to embed Neovim to your app with great ease
https://github.com/rhysd/NyaoVim
MIT License
193 stars 18 forks source link

No bower.json present #30

Closed haifengkao closed 8 years ago

haifengkao commented 8 years ago

When I execute npm start, the terminal shows 2016-07-29 1 54 11

It seems that the bower install in package.json is not necessary

rhysd commented 8 years ago

I don't know why... It actually exists.

https://github.com/rhysd/neovim-component/blob/master/bower.json

haifengkao commented 8 years ago

I know why. It is ignored.

2016-07-29 4 27 39

rhysd commented 8 years ago

Are you using npm package for development?

npm package is made for production, not for development. Please clone this repository instead for development.

rhysd commented 8 years ago

ah, excluding bower_components may be wrong. I'll investigate.

rhysd commented 8 years ago

I checked. Actually not a problem. bower packages are used for development only for this repo. So prodution (npm package) does not need it.

haifengkao commented 8 years ago

I get your point. I indeed use it for development. But it really troubles me if bower.json doesn't present at nyaovim/node_modules/neovim-component. I need to check both nyaovim and neovim-component to find the location of a possible bug.

rhysd commented 8 years ago

I see. I'll add nower.json to npm package. Sorry for inconvenience.