search

rhysd / neovim-component

<neovim-editor> WebComponent to embed Neovim to your app with great ease
https://github.com/rhysd/NyaoVim
MIT License
193 stars 18 forks source link

Fix IME problem #41

Closed chitoku-k closed 7 years ago

chitoku-k commented 7 years ago

What was a problem?

Japanese IME input was not properly handled so they were dropped.

How this PR fixes the problem?

Call input listener to reflect the result of IME composition. Electron calls key related events in following orders:

When starting IME inputting:

  1. keydown
  2. compositionstart
  3. input

When finishing IME inputting:

  1. keydown
  2. input
  3. compositionend

This PR fixes by triggering the very last event after compositionend.

Check lists

rhysd commented 7 years ago

Thank you for this! It looks good. I'll confirm this evening.

rhysd commented 7 years ago

Note: If you're Japanese, feel free to use Japanese for issues or pull requests! (of course English is also OK as this)

chitoku-k commented 7 years ago

ありがとうございます！ （わたしは何語でもかまわないです）

rhysd commented 7 years ago

了解です．では英語が良いかもしれないです（英語圏 or 中国語圏の人もぼちぼち見ている人がいますので…）

rhysd commented 7 years ago

I'm sorry for late. I confirmed.