search

rhysd / neovim-component

<neovim-editor> WebComponent to embed Neovim to your app with great ease
https://github.com/rhysd/NyaoVim
MIT License
193 stars 18 forks source link

Change destination dir of build artifacts #46

Closed yuntan closed 7 years ago

yuntan commented 7 years ago

Change destination dir of .js and .js.map built by tsc to /build, because it is confusing that .js is created in /src.

rhysd commented 7 years ago

Could you describe why it is confusing? It is explicit by its file extension.

rhysd commented 7 years ago

I tried this branch on macOS 10.12.

tmp

It seems that font size is wrong while inputing with IME (before input is determined, font size is bigger).

Can you fix this? Or should I try to fix this in my side?

yuntan commented 7 years ago

There are two reasons. First, when I open a file from Vim's cmd-line, I'm frustrated to choose correct file, because there are three suggestions.

https://gyazo.com/4f862892fb3f24cd818ec3d5d401e9af

Second, I think that separating sources and artifacts is the general view of software compilation process.

If you don't get frustrated to open .ts file and don't agree with the second reason, feel free to ignore this pr and close.

rhysd commented 7 years ago

ok, I understood that it's frustrating rather than confusing. I don't have a strong opinion for this so I'd select your choice.

rhysd commented 7 years ago

Travis CI fails. Tests seem broken.

Error: Cannot find module '../../src/neovim/store'

I think the failure caused because the import paths from test code to library code are wrong. Could you fix them?

yuntan commented 7 years ago

Thank you. It's sorry that my choice of word was wrong.

I simply rewrote require('../../src/neovim/...') to require('../../build/src/neovim/...').

rhysd commented 7 years ago

np. Thank you for this.