search

rhysd / wdio-appium-service

No longer need to launch Appium manually for Webdriver.io
MIT License
9 stars 8 forks source link

Fix eslint errors #9

Closed vovikdrg closed 6 years ago

vovikdrg commented 6 years ago

I see that my previous PR break a build.

I tried to fix as max as i can but i have disabled some eslint rules for specific lines

rhysd commented 6 years ago

From the CI result, npm run lint passed successfully. So I'm merging this PR. Although tests are not passing, it is not a scope of this PR.

rhysd commented 6 years ago

@vovikdrg Thank you for your patch. I merged.

vovikdrg commented 6 years ago

@rhysd do you have any ideas why Travis could fail? I've tested on windows and Mac it works on both. I want to make build green :)

rhysd commented 6 years ago

@vovikdrg

https://travis-ci.org/rhysd/wdio-appium-service/builds/331665843#L322

Error message is

ERROR: connect ECONNREFUSED 127.0.0.1:4723

I'm not sure but ECONNREFUSED occurs generally by